From: Tim Potter <tpot@hp.com>
Date: Sun, 17 Feb 2008 23:24:51 +0000 (+1100)
Subject: Fix off-by-one bugs in subcommand argument passing.
X-Git-Tag: samba-3.2.0pre2~37^2~160^2~100
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d85a2782a483e563a8b68924d4897a145bc25896;p=thirdparty%2Fsamba.git

Fix off-by-one bugs in subcommand argument passing.
---

diff --git a/source/rpcclient/cmd_samr.c b/source/rpcclient/cmd_samr.c
index f8b8ba893ca..8b4ee47a673 100644
--- a/source/rpcclient/cmd_samr.c
+++ b/source/rpcclient/cmd_samr.c
@@ -1044,8 +1044,8 @@ static NTSTATUS cmd_samr_enum_domains(struct rpc_pipe_client *cli,
 		return NT_STATUS_OK;
 	}
 
-	if (argc > 2) {
-		sscanf(argv[2], "%x", &access_mask);
+	if (argc > 1) {
+		sscanf(argv[1], "%x", &access_mask);
 	}
 
 	/* Get sam policy handle */
@@ -1194,11 +1194,11 @@ static NTSTATUS cmd_samr_query_aliasinfo(struct rpc_pipe_client *cli,
 
 	sscanf(argv[2], "%i", &alias_rid);
 
-	if (argc > 3) {
+	if (argc > 2) {
 		level = atoi(argv[3]);
 	}
 
-	if (argc > 4) {
+	if (argc > 3) {
 		sscanf(argv[4], "%x", &access_mask);
 	}