From: Alexander Færøy <ahf@torproject.org>
Date: Sat, 23 Jun 2018 08:33:40 +0000 (+0200)
Subject: Fix memory leak in client_likes_consensus().
X-Git-Tag: tor-0.3.2.11~10^2^2~2^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d86c45bf5cc75a526b884a754d72ef4d11aa0693;p=thirdparty%2Ftor.git

Fix memory leak in client_likes_consensus().

This patches fixes a memory leak in client_likes_consensus() where if
consensus_cache_entry_get_voter_id_digests() would fail we would return
without having free'd the voters list.

See: Coverity CID 1437447
---

diff --git a/src/or/directory.c b/src/or/directory.c
index 5ceea2fb32..f52354356d 100644
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -3499,6 +3499,7 @@ client_likes_consensus(const struct consensus_cache_entry_t *ent,
   int have = 0;
 
   if (consensus_cache_entry_get_voter_id_digests(ent, voters) != 0) {
+    smartlist_free(voters);
     return 1; // We don't know the voters; assume the client won't mind. */
   }