From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Fri, 22 Dec 2023 10:16:30 +0000 (+0100)
Subject: [3.12] gh-65701: document that freeze doesn't work with framework builds on macOS... 
X-Git-Tag: v3.12.2~278
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d8825c2e76e5b0e723fb1210fc2816bbc1b7f56e;p=thirdparty%2FPython%2Fcpython.git

[3.12] gh-65701: document that freeze doesn't work with framework builds on macOS (GH-113352) (#113362)

gh-65701: document that freeze doesn't work with framework builds on macOS (GH-113352)

* gh-65701: document that freeze doesn't work with framework builds on macOS

The framework install is inherently incompatible with freeze. Document
that that freeze doesn't work with framework builds and bail out
early when trying to run freeze anyway.

(cherry picked from commit df1eec3dae3b1eddff819fd70f58b03b3fbd0eda)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
---

diff --git a/Misc/NEWS.d/next/macOS/2023-12-21-10-20-41.gh-issue-65701.Q2hNbN.rst b/Misc/NEWS.d/next/macOS/2023-12-21-10-20-41.gh-issue-65701.Q2hNbN.rst
new file mode 100644
index 000000000000..870b84a4d1af
--- /dev/null
+++ b/Misc/NEWS.d/next/macOS/2023-12-21-10-20-41.gh-issue-65701.Q2hNbN.rst
@@ -0,0 +1,2 @@
+The :program:`freeze` tool doesn't work with framework builds of Python.
+Document this and bail out early when running the tool with such a build.
diff --git a/Tools/freeze/README b/Tools/freeze/README
index 098107c5d1a9..18815fa03fbe 100644
--- a/Tools/freeze/README
+++ b/Tools/freeze/README
@@ -222,6 +222,11 @@ source tree).
 It is possible to create frozen programs that don't have a console
 window, by specifying the option '-s windows'. See the Usage below.
 
+Usage under macOS
+-----------------
+
+On macOS the freeze tool is not supported for framework builds.
+
 Usage
 -----
 
diff --git a/Tools/freeze/freeze.py b/Tools/freeze/freeze.py
index bc5e43f4853d..de9772732cdb 100755
--- a/Tools/freeze/freeze.py
+++ b/Tools/freeze/freeze.py
@@ -136,6 +136,11 @@ def main():
     makefile = 'Makefile'
     subsystem = 'console'
 
+    if sys.platform == "darwin" and sysconfig.get_config_var("PYTHONFRAMEWORK"):
+        print(f"{sys.argv[0]} cannot be used with framework builds of Python", file=sys.stderr)
+        sys.exit(1)
+
+
     # parse command line by first replacing any "-i" options with the
     # file contents.
     pos = 1