From: JINMEI Tatuya <jinmei@isc.org>
Date: Wed, 19 Dec 2012 22:24:22 +0000 (-0800)
Subject: [master] make the use of isspace() more portable regarding signedness of char
X-Git-Tag: bind10-1.0.0-rc-release~95^2~16^2~2^2~21^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d8a4ee26573da0832ad2efc424e6c9db9760fb85;p=thirdparty%2Fkea.git

[master] make the use of isspace() more portable regarding signedness of char

the old code seems to be rejected in an ARM environment

okayed on jabber.
---

diff --git a/src/lib/util/encode/base_n.cc b/src/lib/util/encode/base_n.cc
index 0026a0b616..c38f9017e9 100644
--- a/src/lib/util/encode/base_n.cc
+++ b/src/lib/util/encode/base_n.cc
@@ -291,7 +291,8 @@ BaseNTransformer<BitsPerChunk, BaseZeroCode, Encoder, Decoder>::decode(
                 isc_throw(BadValue, "Too many " << algorithm
                           << " padding characters: " << input);
             }
-        } else if (ch < 0 || !isspace(ch)) {
+        } else if (!(ch > 0 && isspace(ch))) {
+            // see the note for DecodeNormalizer::skipSpaces() above for ch > 0
             break;
         }
         ++srit;