From: Volker Lendecke <vl@samba.org>
Date: Thu, 31 May 2018 18:57:36 +0000 (+0200)
Subject: dns: Simplify logic a bit
X-Git-Tag: tevent-0.9.37~435
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d8acbe73d93d02887583c0f8d7c4dbff1638520a;p=thirdparty%2Fsamba.git

dns: Simplify logic a bit

We don't need a separate boolean variable

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source4/dns_server/dns_crypto.c b/source4/dns_server/dns_crypto.c
index c8b5c46ad30..740e1e4dd53 100644
--- a/source4/dns_server/dns_crypto.c
+++ b/source4/dns_server/dns_crypto.c
@@ -100,7 +100,6 @@ WERROR dns_verify_tsig(struct dns_server *dns,
 	WERROR werror;
 	NTSTATUS status;
 	enum ndr_err_code ndr_err;
-	bool found_tsig = false;
 	uint16_t i, arcount = 0;
 	DATA_BLOB tsig_blob, fake_tsig_blob, sig;
 	uint8_t *buffer = NULL;
@@ -113,12 +112,12 @@ WERROR dns_verify_tsig(struct dns_server *dns,
 	/* Find the first TSIG record in the additional records */
 	for (i=0; i < packet->arcount; i++) {
 		if (packet->additional[i].rr_type == DNS_QTYPE_TSIG) {
-			found_tsig = true;
 			break;
 		}
 	}
 
-	if (!found_tsig) {
+	if (i == packet->arcount) {
+		/* no TSIG around */
 		return WERR_OK;
 	}