From: Lennart Poettering Date: Sat, 14 Aug 2010 17:14:52 +0000 (+0200) Subject: systemctl: skip writing of utmp if we booted using systemd, under the assumption... X-Git-Tag: v8~92 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d90e1a301d61c3808ac5c0aa3093b2ec913e406b;p=thirdparty%2Fsystemd.git systemctl: skip writing of utmp if we booted using systemd, under the assumption that systemd-update-utmp is used --- diff --git a/fixme b/fixme index 26a9787f5c6..e9acede7304 100644 --- a/fixme +++ b/fixme @@ -1,7 +1,7 @@ * dot output for --test showing the 'initial transaction' * check 'disable' - "Warning: Unit file changed in disk, 'systemctl --system daemon-reload' recomended + "Warning: Unit file changed in disk, 'systemctl --system daemon-reload' recommended when does it do that? if you disable the service diff --git a/src/fdset.c b/src/fdset.c index b6d5286f821..ad7cd2949c7 100644 --- a/src/fdset.c +++ b/src/fdset.c @@ -144,7 +144,6 @@ finish: set_free(MAKE_SET(s)); return r; - } int fdset_cloexec(FDSet *fds, bool b) { diff --git a/src/systemctl.c b/src/systemctl.c index 9a85383dbad..167c6a5b7f2 100644 --- a/src/systemctl.c +++ b/src/systemctl.c @@ -4680,9 +4680,12 @@ static int halt_main(DBusConnection *bus) { if (!arg_dry && !arg_immediate) return start_with_fallback(bus); - if (!arg_no_wtmp) - if ((r = utmp_put_shutdown(0)) < 0) + if (!arg_no_wtmp) { + if (sd_booted() > 0) + log_debug("Not writing utmp record, assuming that systemd-update-utmp is used."); + else if ((r = utmp_put_shutdown(0)) < 0) log_warning("Failed to write utmp record: %s", strerror(-r)); + } if (!arg_no_sync) sync();