From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Tue, 18 Nov 2025 08:26:49 +0000 (+0100)
Subject: run: improve log message for unknown user/group
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d92e47a0936477cb068b5f7cff1104419a9591ff;p=thirdparty%2Fsystemd.git

run: improve log message for unknown user/group

Before:
$ sudo build/systemd-run --scope --uid=asdf whoami
Failed to resolve user asdf: No such process
Now:
$ sudo build/systemd-run --scope --uid=asdf whoami
Failed to resolve user 'asdf': Unknown user
---

diff --git a/src/run/run.c b/src/run/run.c
index d1202632ac7..510d4c51ab0 100644
--- a/src/run/run.c
+++ b/src/run/run.c
@@ -2748,7 +2748,8 @@ static int start_transient_scope(sd_bus *bus) {
 
                 r = get_group_creds(&arg_exec_group, &gid, 0);
                 if (r < 0)
-                        return log_error_errno(r, "Failed to resolve group %s: %m", arg_exec_group);
+                        return log_error_errno(r, "Failed to resolve group '%s': %s",
+                                               arg_exec_group, STRERROR_GROUP(r));
 
                 if (setresgid(gid, gid, gid) < 0)
                         return log_error_errno(errno, "Failed to change GID to " GID_FMT ": %m", gid);
@@ -2762,7 +2763,8 @@ static int start_transient_scope(sd_bus *bus) {
                 r = get_user_creds(&arg_exec_user, &uid, &gid, &home, &shell,
                                    USER_CREDS_CLEAN|USER_CREDS_SUPPRESS_PLACEHOLDER|USER_CREDS_PREFER_NSS);
                 if (r < 0)
-                        return log_error_errno(r, "Failed to resolve user %s: %m", arg_exec_user);
+                        return log_error_errno(r, "Failed to resolve user '%s': %s",
+                                               arg_exec_user, STRERROR_USER(r));
 
                 if (home) {
                         r = strv_extendf(&user_env, "HOME=%s", home);