From: Krzysztof Kozlowski Date: Sun, 4 Sep 2016 11:04:15 +0000 (+0200) Subject: ARM: dts: exynos: Fix mismatched value for SD4 pull up/down configuration on exynos4210 X-Git-Tag: v3.16.40~257 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d93ddc2df26d6526ddb9253e97476e1a3617339d;p=thirdparty%2Fkernel%2Fstable.git ARM: dts: exynos: Fix mismatched value for SD4 pull up/down configuration on exynos4210 commit f7061ffb44116490f282f130a220ca2d10849248 upstream. The pinctrl pull up/down register on exynos4210 is 2-bit wide for each pin and it accepts only values of 0, 1 and 3. The pins sd4-bus-width8 were configured with value of 4. The driver does not validate the value so this overflow effectively set a bit 1 in adjacent pins thus configuring them to pull down. The author's intention was probably to set drive strength of 4x. All other bus-widths pins are configured with pull up and drive strength of 4x. Fix this one with same pattern. Fixes: 87711d8c7c70 ("ARM: dts: Add pinctrl node entries for SAMSUNG EXYNOS4210 SoC") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas Reviewed-by: Bartlomiej Zolnierkiewicz Acked-by: Linus Walleij [bwh: Backported to 3.16: use literal constant] Signed-off-by: Ben Hutchings --- diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi index a7c2128916743..160d6f213e372 100644 --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi @@ -647,7 +647,7 @@ sd4_bus8: sd4-bus-width8 { samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6"; samsung,pin-function = <3>; - samsung,pin-pud = <4>; + samsung,pin-pud = <3>; samsung,pin-drv = <3>; };