From: Jeremy Allison <jra@samba.org>
Date: Fri, 6 Sep 2019 22:52:14 +0000 (-0700)
Subject: s3: VFS: vfs_full_audit. Remove mkdir_fn(). No longer used.
X-Git-Tag: talloc-2.3.1~870
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d992708d3d51d86391f218ac72127fbc91d1971b;p=thirdparty%2Fsamba.git

s3: VFS: vfs_full_audit. Remove mkdir_fn(). No longer used.

NB, this will now fail smb_vfs_assert_all_fns()
until we remove the mkdir_fn() from the VFS definitions.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/modules/vfs_full_audit.c b/source3/modules/vfs_full_audit.c
index a3011887a5d..6a70b84774d 100644
--- a/source3/modules/vfs_full_audit.c
+++ b/source3/modules/vfs_full_audit.c
@@ -108,7 +108,6 @@ typedef enum _vfs_op_type {
 	SMB_VFS_OP_SEEKDIR,
 	SMB_VFS_OP_TELLDIR,
 	SMB_VFS_OP_REWINDDIR,
-	SMB_VFS_OP_MKDIR,
 	SMB_VFS_OP_MKDIRAT,
 	SMB_VFS_OP_RMDIR,
 	SMB_VFS_OP_CLOSEDIR,
@@ -255,7 +254,6 @@ static struct {
 	{ SMB_VFS_OP_SEEKDIR,   "seekdir" },
 	{ SMB_VFS_OP_TELLDIR,   "telldir" },
 	{ SMB_VFS_OP_REWINDDIR, "rewinddir" },
-	{ SMB_VFS_OP_MKDIR,	"mkdir" },
 	{ SMB_VFS_OP_MKDIRAT,	"mkdirat" },
 	{ SMB_VFS_OP_RMDIR,	"rmdir" },
 	{ SMB_VFS_OP_CLOSEDIR,	"closedir" },
@@ -998,19 +996,6 @@ static void smb_full_audit_rewinddir(vfs_handle_struct *handle,
 	do_log(SMB_VFS_OP_REWINDDIR, True, handle, "");
 }
 
-static int smb_full_audit_mkdir(vfs_handle_struct *handle,
-		       const struct smb_filename *smb_fname, mode_t mode)
-{
-	int result;
-	
-	result = SMB_VFS_NEXT_MKDIR(handle, smb_fname, mode);
-	
-	do_log(SMB_VFS_OP_MKDIR, (result >= 0), handle, "%s",
-		smb_fname->base_name);
-
-	return result;
-}
-
 static int smb_full_audit_mkdirat(vfs_handle_struct *handle,
 			struct files_struct *dirfsp,
 			const struct smb_filename *smb_fname,
@@ -2879,7 +2864,6 @@ static struct vfs_fn_pointers vfs_full_audit_fns = {
 	.seekdir_fn = smb_full_audit_seekdir,
 	.telldir_fn = smb_full_audit_telldir,
 	.rewind_dir_fn = smb_full_audit_rewinddir,
-	.mkdir_fn = smb_full_audit_mkdir,
 	.mkdirat_fn = smb_full_audit_mkdirat,
 	.rmdir_fn = smb_full_audit_rmdir,
 	.closedir_fn = smb_full_audit_closedir,