From: Roger Dingledine <arma@torproject.org>
Date: Sat, 13 Oct 2007 22:01:24 +0000 (+0000)
Subject: note a bug in directories_have_accepted_server_descriptor() pointed
X-Git-Tag: tor-0.2.0.9-alpha~137
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d9ba4d3e8ba7c192c29c14952fdb16acd8b16622;p=thirdparty%2Ftor.git

note a bug in directories_have_accepted_server_descriptor() pointed
out by weasel


svn:r11914
---

diff --git a/src/or/directory.c b/src/or/directory.c
index 95143449a4..d949ebb1ed 100644
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -192,6 +192,10 @@ directories_have_accepted_server_descriptor(void)
 {
   smartlist_t *servers = router_get_trusted_dir_servers();
   or_options_t *options = get_options();
+  /* XXX020 If any authority of the needed type is down, this
+   * function will never return true. Perhaps we need to be
+   * tolerant of down servers? Or even better, should we change
+   * this so one successful upload is enough? -RD */
   SMARTLIST_FOREACH(servers, trusted_dir_server_t *, d, {
     if ((d->type & options->_PublishServerDescriptor) &&
         !d->has_accepted_serverdesc) {