From: Daan De Meyer <daan@amutable.com>
Date: Tue, 10 Mar 2026 18:56:09 +0000 (+0100)
Subject: ci: Update claude review prompt to insist on valid lines
X-Git-Tag: v260-rc3~34^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d9cd9b2a1d084963627ab5814cd5eb0734d10912;p=thirdparty%2Fsystemd.git

ci: Update claude review prompt to insist on valid lines

Hopefully fixes the failure in
https://github.com/systemd/systemd/actions/runs/22904601370/job/66461528144.
---

diff --git a/.github/workflows/claude-review.yml b/.github/workflows/claude-review.yml
index 4b2a0dc5d63..0f1a52a3054 100644
--- a/.github/workflows/claude-review.yml
+++ b/.github/workflows/claude-review.yml
@@ -187,8 +187,10 @@ jobs:
               Each subagent must return a JSON array of issues:
               `[{"file": "path", "line": <number>, "severity": "must-fix|suggestion|nit", "body": "..."}]`
 
-              `line` must be a line number from the NEW side of the diff (i.e. where the comment
-              should appear in the changed file after the patch is applied).
+              `line` must be a line number from the NEW side of the diff **that appears inside
+              a diff hunk** (i.e. a line that is shown in the patch output). GitHub's review
+              comment API rejects lines outside the diff context, so never reference lines
+              that are not visible in the patch.
 
               Each subagent MUST verify its findings before returning them:
               - For style/convention claims, check at least 3 existing examples in the codebase to confirm