From: Martin Schwenke Date: Wed, 5 Aug 2020 07:40:42 +0000 (+1000) Subject: ctdb-tests: Simplify comment in large database recovery test X-Git-Tag: talloc-2.3.2~556 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d9d8bf8c54c248f14133332444a065f0daeae196;p=thirdparty%2Fsamba.git ctdb-tests: Simplify comment in large database recovery test The older style controls mentioned are being removed. Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs --- diff --git a/ctdb/tests/INTEGRATION/database/recovery.002.large.sh b/ctdb/tests/INTEGRATION/database/recovery.002.large.sh index 4c0f7024a99..3dd0d66e000 100755 --- a/ctdb/tests/INTEGRATION/database/recovery.002.large.sh +++ b/ctdb/tests/INTEGRATION/database/recovery.002.large.sh @@ -2,16 +2,10 @@ # Test recovery of large volatile and persistent databases -# Older style of recovery using PULL_DB and PUSH_DB controls tries to -# construct a single large marshall buffer for all the records in the -# database. However, this approach is problematic as talloc restricts the -# maximum size of buffer to 256M. Also, trying to construct and send large -# buffers is inefficient and can cause CTDB daemon to be tied up for long -# periods of time. - -# Instead new style recovery is introduced using DB_PULL and -# DB_PUSH_START/DB_PUSH_CONFIRM controls. This sends the records in -# batches of ~RecBufferSizeLimit in size at a time. +# Recovery now uses DB_PULL and DB_PUSH_START/DB_PUSH_CONFIRM +# controls. This sends the records in batches of ~RecBufferSizeLimit +# in size at a time. Test that large databases are re-assembled +# correctly. . "${TEST_SCRIPTS_DIR}/integration.bash"