From: Liang Yan Date: Tue, 26 Apr 2022 20:38:26 +0000 (-0400) Subject: qemu: do not use domain virt type to get default version X-Git-Tag: v8.4.0-rc1~274 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d9f175379c4f6f9fd7edea5a8790dfcd657d4cb4;p=thirdparty%2Flibvirt.git qemu: do not use domain virt type to get default version We do not need VIR_DOMAIN_VIRT_QEMU to get qemu default version. With the 'os_type' and 'arch'in capabilities, we could identify 'emulator' which is enough to get the version. Actually VIR_DOMAIN_VIRT_QEMU is not the only domain virt type for qemu driver, there are VIR_DOMAIN_VIRT_KVM and VIR_DOMAIN_VIRT_HVF. If TCG is disabled in qemu, it will cause the error that could not find suitable emulater when access version. Signed-off-by: Liang Yan Reviewed-by: Michal Privoznik --- diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index b91db851bb..9a0b7ebeb4 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1857,7 +1857,7 @@ int virQEMUCapsGetDefaultVersion(virCaps *caps, hostarch = virArchFromHost(); if (!(capsdata = virCapabilitiesDomainDataLookup(caps, - VIR_DOMAIN_OSTYPE_HVM, hostarch, VIR_DOMAIN_VIRT_QEMU, + VIR_DOMAIN_OSTYPE_HVM, hostarch, VIR_DOMAIN_VIRT_NONE, NULL, NULL))) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Cannot find suitable emulator for %s"),