From: Matthijs Mekking <matthijs@isc.org>
Date: Thu, 25 Apr 2024 15:28:06 +0000 (+0200)
Subject: Rename create_cds to create_ksk
X-Git-Tag: v9.20.0~56^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=d9fb2054f1dfa640a8a794004e7a2c07dd74f5b4;p=thirdparty%2Fbind9.git

Rename create_cds to create_ksk

Now that this function also creates the DNSKEY record for the KSKs,
as well as other associated records such as CDS and CDNSKEY, rename
the function to something slightly better.
---

diff --git a/bin/dnssec/dnssec-ksr.c b/bin/dnssec/dnssec-ksr.c
index bfd67cba038..bcbcf5857ae 100644
--- a/bin/dnssec/dnssec-ksr.c
+++ b/bin/dnssec/dnssec-ksr.c
@@ -680,8 +680,12 @@ sign_rrset(ksr_ctx_t *ksr, isc_stdtime_t inception, isc_stdtime_t expiration,
 	freerrset(&rrsigset);
 }
 
+/*
+ * Create the DNSKEY, CDS, and CDNSKEY records beloing to the KSKs
+ * listed in 'keys'.
+ */
 static void
-create_cds(ksr_ctx_t *ksr, dns_kasp_t *kasp, dns_dnsseckeylist_t *keys,
+create_ksk(ksr_ctx_t *ksr, dns_kasp_t *kasp, dns_dnsseckeylist_t *keys,
 	   dns_rdataset_t *dnskeyset, dns_rdataset_t *cdnskeyset,
 	   dns_rdataset_t *cdsset) {
 	dns_rdatalist_t *dnskeylist = isc_mem_get(mctx, sizeof(*dnskeylist));
@@ -1037,7 +1041,7 @@ sign(ksr_ctx_t *ksr) {
 	}
 
 	/* KSK, CDS and CDNSKEY */
-	create_cds(ksr, kasp, &keys, &ksk, &cdnskey, &cds);
+	create_ksk(ksr, kasp, &keys, &ksk, &cdnskey, &cds);
 
 	for (ret = isc_lex_gettoken(lex, opt, &token); ret == ISC_R_SUCCESS;
 	     ret = isc_lex_gettoken(lex, opt, &token))