From: amosjeffries <>
Date: Thu, 2 Aug 2007 08:52:01 +0000 (+0000)
Subject: Coverity detected a code-path in helpers/ntlm_auth/SMB/ntlm_auth.c
X-Git-Tag: SQUID_3_0_PRE7~125
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=db03754a094fd85ad9d32eeb0d621eda4916f4db;p=thirdparty%2Fsquid.git

Coverity detected a code-path in helpers/ntlm_auth/SMB/ntlm_auth.c
 that dereferences NULL credentials.
Added an assert to check for the condition in real-use.
Possibly need to add a default case to the switch on line 360.
---

diff --git a/helpers/ntlm_auth/SMB/ntlm_auth.c b/helpers/ntlm_auth/SMB/ntlm_auth.c
index cf987b9085..8355dd7e61 100644
--- a/helpers/ntlm_auth/SMB/ntlm_auth.c
+++ b/helpers/ntlm_auth/SMB/ntlm_auth.c
@@ -273,7 +273,7 @@ manage_request()
     ntlmhdr *fast_header;
     char buf[BUFFER_SIZE];
     const char *ch;
-    char *ch2, *decoded, *cred;
+    char *ch2, *decoded, *cred = NULL;
     int plen;
 
     if (fgets(buf, BUFFER_SIZE, stdin) == NULL) {
@@ -414,6 +414,7 @@ manage_request()
 		    return;
 		}
 	    }
+            assert(cred != NULL);
 	    lc(cred);		/* let's lowercase them for our convenience */
 	    SEND2("AF %s", cred);
 	    return;