From: Christian Göttsche <cgzones@googlemail.com>
Date: Sat, 11 Jul 2020 19:12:08 +0000 (+0200)
Subject: shared: fix error handling in make_inaccessible_nodes
X-Git-Tag: v246-rc2~89^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=db06c162e8c077e6c6844e14bdf70c5ef8a40a4e;p=thirdparty%2Fsystemd.git

shared: fix error handling in make_inaccessible_nodes

_label wrappers return -errno on failure instead of returning -1 and
setting global errno.

Fixes: 8d9cbd809db492df9d94c0c664bd0d2e53416531
Follow up: #16426
---

diff --git a/src/shared/dev-setup.c b/src/shared/dev-setup.c
index 7641909c1b2..6e57e2a99d3 100644
--- a/src/shared/dev-setup.c
+++ b/src/shared/dev-setup.c
@@ -107,8 +107,8 @@ int make_inaccessible_nodes(
                 else
                         r = mknod_label(path, table[i].mode, makedev(0, 0));
                 if (r < 0) {
-                        if (errno != EEXIST)
-                                log_debug_errno(errno, "Failed to create '%s', ignoring: %m", path);
+                        if (r != -EEXIST)
+                                log_debug_errno(r, "Failed to create '%s', ignoring: %m", path);
                         continue;
                 }