From: Andreas Schneider <asn@samba.org>
Date: Mon, 5 Mar 2018 07:43:17 +0000 (+0100)
Subject: ldb: Directly return an error and do not fall through
X-Git-Tag: talloc-2.1.12~268
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=db4d72d21c263dc50851dc9b36ee0de61ee5fef2;p=thirdparty%2Fsamba.git

ldb: Directly return an error and do not fall through

Detected by -Wimplicit-fallthrough.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlet <abartlet@samba.org>
---

diff --git a/lib/ldb/ldb_tdb/ldb_index.c b/lib/ldb/ldb_tdb/ldb_index.c
index 17cb267be78..739cab0e254 100644
--- a/lib/ldb/ldb_tdb/ldb_index.c
+++ b/lib/ldb/ldb_tdb/ldb_index.c
@@ -1862,7 +1862,7 @@ int ltdb_search_indexed(struct ltdb_context *ac, uint32_t *match_count)
 		 * The only caller will have filtered the operation out
 		 * so we should never get here
 		 */
-		ldb_operr(ldb);
+		return ldb_operr(ldb);
 
 	case LDB_SCOPE_ONELEVEL:
 		/*