From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 3 May 2021 03:55:01 +0000 (+1200)
Subject: libsmb: Remove overflow check
X-Git-Tag: tevent-0.11.0~811
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=db5b34c7682e36630908356cf674fddd18d8fa1f;p=thirdparty%2Fsamba.git

libsmb: Remove overflow check

Pointer overflow is undefined, so this check does not accomplish
anything.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/source3/libsmb/clifsinfo.c b/source3/libsmb/clifsinfo.c
index a9b3b03abb6..135a77f2312 100644
--- a/source3/libsmb/clifsinfo.c
+++ b/source3/libsmb/clifsinfo.c
@@ -650,7 +650,7 @@ static void cli_posix_whoami_done(struct tevent_req *subreq)
 	 * parsing network packets in C.
 	 */
 
-	if (num_rdata < 40 || rdata + num_rdata < rdata) {
+	if (num_rdata < 40) {
 		tevent_req_nterror(req, NT_STATUS_INVALID_NETWORK_RESPONSE);
 		return;
 	}