From: Nick Porter <nick@portercomputing.co.uk>
Date: Fri, 22 Jan 2021 11:18:06 +0000 (+0000)
Subject: Correct order of parameters in eap_packet_to_vp()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=db5cf233aa46fd329ffc5f34ff57fcc221537a29;p=thirdparty%2Ffreeradius-server.git

Correct order of parameters in eap_packet_to_vp()
---

diff --git a/src/lib/eap/base.c b/src/lib/eap/base.c
index f6aeaebc700..0bf6af837f1 100644
--- a/src/lib/eap/base.c
+++ b/src/lib/eap/base.c
@@ -115,7 +115,7 @@ fr_dict_attr_autoload_t eap_base_dict_attr[] = {
 	{ NULL }
 };
 
-void eap_packet_to_vp(fr_radius_packet_t *packet, eap_packet_raw_t const *eap, fr_pair_list_t *list)
+void eap_packet_to_vp(TALLOC_CTX *ctx, fr_pair_list_t *list, eap_packet_raw_t const *eap)
 {
 	int		total, size;
 	uint8_t const *ptr;
@@ -134,7 +134,7 @@ void eap_packet_to_vp(fr_radius_packet_t *packet, eap_packet_raw_t const *eap, f
 		size = total;
 		if (size > 253) size = 253;
 
-		MEM(vp = fr_pair_afrom_da(packet, attr_eap_message));
+		MEM(vp = fr_pair_afrom_da(ctx, attr_eap_message));
 		fr_pair_value_memdup(vp, ptr, size, false);
 
 		fr_pair_add(list, vp);
diff --git a/src/lib/eap/base.h b/src/lib/eap/base.h
index 6e12cd53d11..c53da011b45 100644
--- a/src/lib/eap/base.h
+++ b/src/lib/eap/base.h
@@ -68,7 +68,7 @@ typedef struct {
 /*
  *	interfaces in eapcommon.c
  */
-void			eap_packet_to_vp(fr_radius_packet_t *packet, eap_packet_raw_t const *reply, fr_pair_list_t *list);
+void			eap_packet_to_vp(TALLOC_CTX *ctx, fr_pair_list_t *list, eap_packet_raw_t const *reply);
 eap_packet_raw_t	*eap_packet_from_vp(TALLOC_CTX *ctx, fr_pair_list_t *vps);
 void			eap_add_reply(request_t *request, fr_dict_attr_t const *da, uint8_t const *value, int len);