From: Christian Heimes <christian@cheimes.de>
Date: Tue, 29 Oct 2013 11:14:55 +0000 (+0100)
Subject: Issue #19420: Fix reference leak in module initalization code of _hashopenssl.c
X-Git-Tag: v3.4.0b1~482
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=db816d65464051ffa1aa2cce59dc7df721bbe873;p=thirdparty%2FPython%2Fcpython.git

Issue #19420: Fix reference leak in module initalization code of _hashopenssl.c
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 5e6a17b2616f..55403e9efdfe 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -28,6 +28,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #19420: Fix reference leak in module initalization code of
+  _hashopenssl.c
+
 - Issue #19329: Optimized compiling charsets in regular expressions.
 
 - Issue #19227: Try to fix deadlocks caused by re-seeding then OpenSSL
diff --git a/Modules/_hashopenssl.c b/Modules/_hashopenssl.c
index 423b3b3a4764..a4f610450e43 100644
--- a/Modules/_hashopenssl.c
+++ b/Modules/_hashopenssl.c
@@ -717,9 +717,9 @@ _openssl_hash_name_mapper(const OBJ_NAME *openssl_obj_name, void *arg)
         state->error = 1;
     } else {
         if (PySet_Add(state->set, py_name) != 0) {
-            Py_DECREF(py_name);
             state->error = 1;
         }
+        Py_DECREF(py_name);
     }
 }