From: Michal 'vorner' Vaner <michal.vaner@nic.cz>
Date: Fri, 26 Oct 2012 18:09:21 +0000 (+0200)
Subject: [2209] Test ZoneTableSegmentLocal
X-Git-Tag: trac2487_base~21^2~8^2~7
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dba0f070ef3f4a78db630b3002eef5fd2ba757e0;p=thirdparty%2Fkea.git

[2209] Test ZoneTableSegmentLocal

And not ZoneTableSegmentTest like before. Testing a mock class (and not
testing the real class) makes no sense.
---

diff --git a/src/lib/datasrc/memory/zone_table_segment_local.cc b/src/lib/datasrc/memory/zone_table_segment_local.cc
index fcb25f9cd3..ca46b126f2 100644
--- a/src/lib/datasrc/memory/zone_table_segment_local.cc
+++ b/src/lib/datasrc/memory/zone_table_segment_local.cc
@@ -30,6 +30,7 @@ ZoneTableSegmentLocal::ZoneTableSegmentLocal(const RRClass& rrclass) :
 
 ZoneTableSegmentLocal::~ZoneTableSegmentLocal() {
     ZoneTable::destroy(mem_sgmt_, header_.getTable());
+    assert(mem_sgmt_.allMemoryDeallocated());
 }
 
 // After more methods' definitions are added here, it would be a good
diff --git a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
index 16793fcbb4..ac114e282c 100644
--- a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
+++ b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
@@ -12,7 +12,6 @@
 // OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
 // PERFORMANCE OF THIS SOFTWARE.
 
-#include "zone_table_segment_test.h"
 #include <datasrc/memory/zone_writer_local.h>
 #include <datasrc/memory/zone_table_segment_local.h>
 #include <util/memory_segment_local.h>
@@ -32,23 +31,15 @@ namespace {
 class ZoneTableSegmentTest : public ::testing::Test {
 protected:
     ZoneTableSegmentTest() :
-        ztable_segment_(new test::ZoneTableSegmentTest(RRClass::IN(),
-                                                       mem_sgmt_))
+        ztable_segment_(ZoneTableSegment::create(isc::data::NullElement(),
+                                                 RRClass::IN()))
     {}
 
-    ~ZoneTableSegmentTest() {
-        delete ztable_segment_;
-    }
-
     void TearDown() {
         ZoneTableSegment::destroy(ztable_segment_);
         ztable_segment_ = NULL;
-
-        // Catch any future leaks here.
-        EXPECT_TRUE(mem_sgmt_.allMemoryDeallocated());
     }
 
-    MemorySegmentLocal mem_sgmt_;
     ZoneTableSegment* ztable_segment_;
 };