From: Vsevolod Stakhov Date: Thu, 5 Jan 2017 12:44:33 +0000 (+0000) Subject: [CritFix] Do not trust remote shingles count X-Git-Tag: 1.4.2~2^2~1 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dbffb41c38bddd4928784ba616aa118fb650081f;p=thirdparty%2Frspamd.git [CritFix] Do not trust remote shingles count MFH: true --- diff --git a/src/libserver/fuzzy_backend_redis.c b/src/libserver/fuzzy_backend_redis.c index b89dde8cc8..3804e9fd0c 100644 --- a/src/libserver/fuzzy_backend_redis.c +++ b/src/libserver/fuzzy_backend_redis.c @@ -464,7 +464,7 @@ rspamd_fuzzy_backend_check_shingles (struct rspamd_fuzzy_redis_session *session) rspamd_fuzzy_redis_session_free_args (session); /* First of all check digest */ - session->nargs = session->cmd->shingles_count + 1; + session->nargs = RSPAMD_SHINGLE_SIZE + 1; session->argv = g_malloc (sizeof (gchar *) * session->nargs); session->argv_lens = g_malloc (sizeof (gsize) * session->nargs); shcmd = (const struct rspamd_fuzzy_shingle_cmd *)session->cmd; @@ -484,7 +484,6 @@ rspamd_fuzzy_backend_check_shingles (struct rspamd_fuzzy_redis_session *session) g_assert (session->ctx != NULL); - if (redisAsyncCommandArgv (session->ctx, rspamd_fuzzy_redis_shingles_callback, session, session->nargs, (const gchar **)session->argv, session->argv_lens) != REDIS_OK) {