From: Alexander Færøy <ahf@torproject.org>
Date: Sat, 23 Jun 2018 08:27:10 +0000 (+0200)
Subject: Fix potential memory leak in hs_helper_build_hs_desc_impl().
X-Git-Tag: tor-0.3.2.11~10^2^2~2^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dc2384da30cae716f512dedef37d27f00c43f29d;p=thirdparty%2Ftor.git

Fix potential memory leak in hs_helper_build_hs_desc_impl().

This patch fixes a memory leak in hs_helper_build_hs_desc_impl() where
if a test assertion would fail we would leak the storage that `desc`
points to.

See: Coverity CID 1437448
---

diff --git a/src/test/hs_test_helpers.c b/src/test/hs_test_helpers.c
index f7e054b1d1..dcd58bc5fd 100644
--- a/src/test/hs_test_helpers.c
+++ b/src/test/hs_test_helpers.c
@@ -142,6 +142,9 @@ hs_helper_build_hs_desc_impl(unsigned int no_ip,
 
   descp = desc;
  done:
+  if (descp == NULL)
+    tor_free(desc);
+
   return descp;
 }