From: Volker Lendecke <vl@samba.org>
Date: Sat, 15 Mar 2008 20:47:22 +0000 (+0100)
Subject: Allocate one 0-byte in asprintf replacement when len==0
X-Git-Tag: samba-3.3.0pre1~3301
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dc3d5e16452bf30055638ba3cfe99097fb557156;p=thirdparty%2Fsamba.git

Allocate one 0-byte in asprintf replacement when len==0

Some S3 code depends on this.
---

diff --git a/source/lib/replace/snprintf.c b/source/lib/replace/snprintf.c
index 9f8a7657e52..a174dcffed7 100644
--- a/source/lib/replace/snprintf.c
+++ b/source/lib/replace/snprintf.c
@@ -1264,7 +1264,7 @@ static int add_cnk_list_entry(struct pr_chunk_x **list,
 	VA_COPY(ap2, ap);
 	ret = vsnprintf(NULL, 0, format, ap2);
 	va_end(ap2);
-	if (ret <= 0) return ret;
+	if (ret < 0) return ret;
 
 	(*ptr) = (char *)malloc(ret+1);
 	if (!*ptr) return -1;