From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Wed, 24 Oct 2018 21:35:16 +0000 (+0900)
Subject: udev-event: check command is not empty before executing
X-Git-Tag: v240~453^2~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dc8aec36a61ef32fa13d0f3823053488a8ec8ab1;p=thirdparty%2Fsystemd.git

udev-event: check command is not empty before executing
---

diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c
index 2125a6fa0dc..125b4005b1a 100644
--- a/src/udev/udev-event.c
+++ b/src/udev/udev-event.c
@@ -586,6 +586,8 @@ int udev_event_spawn(struct udev_event *event,
         pid_t pid;
         int r;
 
+        assert(event);
+        assert(event->dev);
         assert(result || ressize == 0);
 
         /* pipes from child to parent */
@@ -601,6 +603,11 @@ int udev_event_spawn(struct udev_event *event,
         if (!argv)
                 return log_oom();
 
+        if (isempty(argv[0])) {
+                log_error("Invalid command '%s'", cmd);
+                return -EINVAL;
+        }
+
         /* allow programs in /usr/lib/udev/ to be called without the path */
         if (!path_is_absolute(argv[0])) {
                 char *program;