From: Jose Quaresma Date: Fri, 13 Mar 2026 17:16:35 +0000 (+0000) Subject: lib/oe/patch: add user and email when patchtool is git X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dcac7775f2c2d310c9d2e14da52e85fa9ca5fc9f;p=thirdparty%2Fopenembedded%2Fopenembedded-core.git lib/oe/patch: add user and email when patchtool is git When the PATCHTOOL=git, oe-core creates a git repo for the sources with: git init git add . git commit The git commit can fails blindly due to misconfigured user when git don't have the email proper configured. Although the commit command does not fail because it returns 0, it is not executed and the tree remains with all files staged so the following git commands can fail and fails in some cases. This problem has been particularly observed in some obscure and little-used cases in openembedded-core like patching the linux-firmware which only works using PATCHTOOL=git because it deals with binary files. Signed-off-by: Jose Quaresma Signed-off-by: Richard Purdie --- diff --git a/meta/lib/oe/patch.py b/meta/lib/oe/patch.py index afc42df8a7..2cd8de22c7 100644 --- a/meta/lib/oe/patch.py +++ b/meta/lib/oe/patch.py @@ -318,6 +318,8 @@ class GitApplyTree(PatchTree): def _initRepo(self): runcmd("git init".split(), self.dir) + runcmd(["git", "config", "user.email", self.commitemail], self.dir) + runcmd(["git", "config", "user.name", self.commituser], self.dir) runcmd("git add .".split(), self.dir) runcmd("git commit -a --allow-empty -m bitbake_patching_started".split(), self.dir)