From: Jelte Jansen <jelte@isc.org>
Date: Fri, 15 Jun 2012 07:51:27 +0000 (+0200)
Subject: [2027] update rationale comment about acl check
X-Git-Tag: trac2351_base~97^2~9^2~3^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dcafee23dccbdf2f4b77ffc57d4a485ab4334455;p=thirdparty%2Fkea.git

[2027] update rationale comment about acl check
---

diff --git a/src/lib/python/isc/ddns/session.py b/src/lib/python/isc/ddns/session.py
index 5cadb60acb..366bc8b75f 100644
--- a/src/lib/python/isc/ddns/session.py
+++ b/src/lib/python/isc/ddns/session.py
@@ -243,8 +243,10 @@ class UpdateSession:
         try:
             self._get_update_zone()
             # Contrary to what RFC2136 specifies, we do ACL checks before
-            # prerequisites. Following the spec, information could leak,
-            # and we decided not to do so (as do other implementations)
+            # prerequisites. It's now generally considered to be a bad
+            # idea, and actually does harm such as information
+            # leak. It should make more sense to prevent any security issues
+            # by performing ACL check as early as possible.
             self.__check_update_acl(self.__zname, self.__zclass)
             self._create_diff()
             prereq_result = self.__check_prerequisites()