From: Alexander Færøy <ahf@torproject.org>
Date: Sat, 23 Jun 2018 01:24:10 +0000 (+0200)
Subject: Fix memory leak in frac_nodes_with_descriptors().
X-Git-Tag: tor-0.2.9.16~9^2^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dcbfee246f35970f65d08a4555e25b956b9aba9c;p=thirdparty%2Ftor.git

Fix memory leak in frac_nodes_with_descriptors().

This patch fixes a memory leak in frac_nodes_with_descriptors() where
we might return without free'ing the bandwidths variable.

See: Coverity CID 1437451.
---

diff --git a/src/or/routerlist.c b/src/or/routerlist.c
index f21a222cd2..f73ec9baa1 100644
--- a/src/or/routerlist.c
+++ b/src/or/routerlist.c
@@ -2765,6 +2765,8 @@ frac_nodes_with_descriptors(const smartlist_t *sl,
       if (node_has_descriptor(node))
         n_with_descs++;
     });
+
+    tor_free(bandwidths);
     return ((double)n_with_descs) / (double)smartlist_len(sl);
   }