From: Russ Combs <rucombs@cisco.com>
Date: Fri, 28 Nov 2014 15:12:53 +0000 (-0500)
Subject: reprioritize some fixits
X-Git-Tag: 3.0.0-233~1152^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dd17e61808b0e5c83c6029bfaaaec12434a7db3c;p=thirdparty%2Fsnort3.git

reprioritize some fixits
---

diff --git a/src/detection/detection_options.cc b/src/detection/detection_options.cc
index 74a4815c5..5a989aa31 100644
--- a/src/detection/detection_options.cc
+++ b/src/detection/detection_options.cc
@@ -853,7 +853,7 @@ static void detection_option_node_update_otn_stats(
     if (node->option_type == RULE_OPTION_TYPE_LEAF_NODE)
     {
         /* Update stats for this otn */
-        // FIXIT-H should be sum of instances (only called from main thread)
+        // FIXIT-M should be sum of instances (only called from main thread)
         OptTreeNode *otn = (OptTreeNode *)node->option_data;
         OtnState* state = otn->state + get_instance_id();
         state->ticks += local_stats.ticks;
diff --git a/src/events/event_wrapper.cc b/src/events/event_wrapper.cc
index 81b299f0b..bef5e29a3 100644
--- a/src/events/event_wrapper.cc
+++ b/src/events/event_wrapper.cc
@@ -75,7 +75,7 @@ uint32_t GenerateSnortEvent(Packet *p, uint32_t gid, uint32_t sid)
 
     fpLogEvent(rtn, otn, p);
 
-    return 0;  //otn->event_data.event_id; // FIXIT-H EVENT
+    return 0;  //otn->event_data.event_id; // FIXIT-M EVENT
 }
 
 /**
diff --git a/src/main/policy.h b/src/main/policy.h
index 51a02af00..1456f2f96 100644
--- a/src/main/policy.h
+++ b/src/main/policy.h
@@ -160,7 +160,7 @@ public:
     Shell* get_shell(unsigned i = 0)
     { return i < shells.size() ? shells[i] : nullptr; };
 
-public:  // FIXIT-H make impl private
+public:  // FIXIT-M make impl private
     std::vector<Shell*> shells;
     std::vector<InspectionPolicy*> inspection_policy;
     std::vector<IpsPolicy*> ips_policy;
diff --git a/src/stream/stream_splitter.cc b/src/stream/stream_splitter.cc
index 86103c8a5..562fb3d2e 100644
--- a/src/stream/stream_splitter.cc
+++ b/src/stream/stream_splitter.cc
@@ -89,7 +89,7 @@ void AtomSplitter::update()
 }
 
 #if 0
-// FIXIT-H this should be part of a new splitter
+// FIXIT-M this should be part of a new splitter
 static inline int CheckFlushCoercion (
     Packet* p, FlushMgr* fm, uint16_t flush_factor
 ) {
diff --git a/src/stream/tcp/ips_stream_reassemble.cc b/src/stream/tcp/ips_stream_reassemble.cc
index c9bade7ec..6fcf2d84a 100644
--- a/src/stream/tcp/ips_stream_reassemble.cc
+++ b/src/stream/tcp/ips_stream_reassemble.cc
@@ -132,8 +132,8 @@ int ReassembleOption::eval(Cursor&, Packet* pkt)
     }
     else
     {
-        // FIXIT-H PAF need to instantiate service splitter?
-        // FIXIT-H PAF need to check for ips / on-data
+        // FIXIT-M PAF need to instantiate service splitter?
+        // FIXIT-M PAF need to check for ips / on-data
         if ( srod.direction & SSN_DIR_SERVER )
         {
             tcpssn->server.flush_policy = STREAM_FLPOLICY_ON_ACK;