From: Andreas Schneider Date: Fri, 5 Jul 2024 12:00:11 +0000 (+0200) Subject: libcli:nbt: Initialize struct nbt_name_register X-Git-Tag: tdb-1.4.11~133 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ddadbddb401613258332359bc9c35069445070c9;p=thirdparty%2Fsamba.git libcli:nbt: Initialize struct nbt_name_register "Error: UNINIT (CWE-457): samba-4.20.0rc2/libcli/nbt/pynbt.c:277: var_decl: Declaring variable ""io"" without initializer. samba-4.20.0rc2/libcli/nbt/pynbt.c:305: uninit_use_in_call: Using uninitialized value ""io.in.nb_flags"" when calling ""nbt_name_register"". 303| return NULL; 304| 305|-> status = nbt_name_register(node->socket, NULL, &io); 306| 307| if (NT_STATUS_IS_ERR(status)) {" Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner --- diff --git a/libcli/nbt/pynbt.c b/libcli/nbt/pynbt.c index e0a72fa8451..18ae369b695 100644 --- a/libcli/nbt/pynbt.c +++ b/libcli/nbt/pynbt.c @@ -141,7 +141,7 @@ err: return false; } -static PyObject *PyObject_FromNBTName(struct nbt_name_socket *name_socket, +static PyObject *PyObject_FromNBTName(struct nbt_name_socket *name_socket, struct nbt_name *name) { if (name->scope) { @@ -274,7 +274,7 @@ static PyObject *py_nbt_name_register(PyObject *self, PyObject *args, PyObject * { nbt_node_Object *node = (nbt_node_Object *)self; PyObject *ret, *py_dest, *py_name; - struct nbt_name_register io; + struct nbt_name_register io = {}; NTSTATUS status; const char *kwnames[] = { "name", "address", "dest", "register_demand", "broadcast",