From: Karel Slany <karel.slany@nic.cz>
Date: Mon, 29 Jun 2015 15:09:07 +0000 (+0200)
Subject: layer/rrsigcache: Fixed return value of stash_add_rrsig().
X-Git-Tag: v1.0.0-beta1~53^2~174
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=de3275405ba6f509bf1645d5c8fa451f4db1f6f9;p=thirdparty%2Fknot-resolver.git

layer/rrsigcache: Fixed return value of stash_add_rrsig().
---

diff --git a/lib/layer/rrsigcache.c b/lib/layer/rrsigcache.c
index dfe3fdd1e..6c5b8228c 100644
--- a/lib/layer/rrsigcache.c
+++ b/lib/layer/rrsigcache.c
@@ -135,12 +135,15 @@ static int stash_add_rrsig(map_t *stash, const knot_pktsection_t *section,
 
 	if (cache_rrsig.rrs.rr_count) {
 		stashed = knot_rrset_copy(&cache_rrsig, pool);
+		if (!stashed) {
+			return kr_error(ENOMEM);
+		}
 	}
 	knot_rrset_clear(&cache_rrsig, pool);
-	if (!stashed) {
-		return kr_error(ENOMEM);
+	if (stashed) {
+		return map_set(stash, key, stashed);
 	}
-	return map_set(stash, key, stashed);
+	return kr_ok();
 }
 
 static void stash_glue(map_t *stash, knot_pkt_t *pkt, const knot_dname_t *ns_name, mm_ctx_t *pool)