From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Wed, 7 May 2025 13:24:36 +0000 (+0100)
Subject: libkmod: don't reset errno in kmod_file_load_zlib()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=df0f98bd34e373b352deacf35abfd0795a7f864b;p=thirdparty%2Fkmod.git

libkmod: don't reset errno in kmod_file_load_zlib()

Currently we reset errno, shortly to be followed by an fcntl() and
gzdopen() calls. Both of those should set errno on failure and preserve
it on success.

Just leave errno as-is, we shouldn't be changing it in this context.

Reference: https://github.com/kmod-project/kmod/issues/244
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
---

diff --git a/libkmod/libkmod-file-zlib.c b/libkmod/libkmod-file-zlib.c
index b26c7d1e..d4e0f8c3 100644
--- a/libkmod/libkmod-file-zlib.c
+++ b/libkmod/libkmod-file-zlib.c
@@ -60,7 +60,6 @@ int kmod_file_load_zlib(struct kmod_file *file)
 		return -EINVAL;
 	}
 
-	errno = 0;
 	gzfd = fcntl(file->fd, F_DUPFD_CLOEXEC, 3);
 	if (gzfd < 0)
 		return -errno;