From: Mathieu Parent <math.parent@gmail.com>
Date: Thu, 11 Jan 2018 09:07:17 +0000 (+0100)
Subject: systemd: syslog.target is obsolete
X-Git-Tag: samba-4.8.0rc1~7
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=df68af9fa5900b5f7b22a972666fd213fef17106;p=thirdparty%2Fsamba.git

systemd: syslog.target is obsolete

After=syslog.target is unnecessary by now because syslog is
socket-activated and will therefore be started when needed.

Ref: https://lintian.debian.org/tags/systemd-service-file-refers-to-obsolete-target.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12402

Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
---

diff --git a/packaging/systemd/nmb.service.in b/packaging/systemd/nmb.service.in
index b0ba92f2244..bfda34e092d 100644
--- a/packaging/systemd/nmb.service.in
+++ b/packaging/systemd/nmb.service.in
@@ -1,7 +1,7 @@
 [Unit]
 Description=Samba NMB Daemon
 Wants=network-online.target
-After=syslog.target network.target network-online.target
+After=network.target network-online.target
 
 [Service]
 Type=notify
diff --git a/packaging/systemd/samba.service.in b/packaging/systemd/samba.service.in
index c4181509461..74ac68dc8cc 100644
--- a/packaging/systemd/samba.service.in
+++ b/packaging/systemd/samba.service.in
@@ -1,7 +1,7 @@
 [Unit]
 Description=Samba AD Daemon
 Wants=network-online.target
-After=syslog.target network.target network-online.target
+After=network.target network-online.target
 
 [Service]
 Type=notify
diff --git a/packaging/systemd/smb.service.in b/packaging/systemd/smb.service.in
index f829bcbaee5..fe151cce55b 100644
--- a/packaging/systemd/smb.service.in
+++ b/packaging/systemd/smb.service.in
@@ -1,6 +1,6 @@
 [Unit]
 Description=Samba SMB Daemon
-After=syslog.target network.target nmb.service winbind.service
+After=network.target nmb.service winbind.service
 
 [Service]
 Type=notify
diff --git a/packaging/systemd/winbind.service.in b/packaging/systemd/winbind.service.in
index 5ac5adc846f..f490103904b 100644
--- a/packaging/systemd/winbind.service.in
+++ b/packaging/systemd/winbind.service.in
@@ -1,6 +1,6 @@
 [Unit]
 Description=Samba Winbind Daemon
-After=syslog.target network.target nmb.service
+After=network.target nmb.service
 
 [Service]
 Type=notify