From: Andrew Donnellan Date: Mon, 1 Jul 2019 08:04:53 +0000 (+1000) Subject: tests: Add test for unescaped values in patch detail page X-Git-Tag: v2.2.0-rc1~108 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=df80e690bcc32d483875dcb36b488764c89ec9b6;p=thirdparty%2Fpatchwork.git tests: Add test for unescaped values in patch detail page Add a test to check whether we are escaping values from the Patch model on the patch detail page. This test shouldn't be relied upon as proof that we've escaped everything correctly, but may help catch regressions. Signed-off-by: Andrew Donnellan Signed-off-by: Daniel Axtens --- diff --git a/patchwork/tests/test_detail.py b/patchwork/tests/test_detail.py index 4ca1c9cd..18408ecb 100644 --- a/patchwork/tests/test_detail.py +++ b/patchwork/tests/test_detail.py @@ -34,6 +34,23 @@ class PatchViewTest(TestCase): response = self.client.get(requested_url) self.assertRedirects(response, redirect_url) + def test_escaping(self): + # Warning: this test doesn't guarantee anything - it only tests some + # fields + unescaped_string = 'blahTESTblah' + patch = create_patch() + patch.diff = unescaped_string + patch.commit_ref = unescaped_string + patch.pull_url = unescaped_string + patch.name = unescaped_string + patch.msgid = unescaped_string + patch.headers = unescaped_string + patch.content = unescaped_string + patch.save() + requested_url = reverse('patch-detail', kwargs={'patch_id': patch.id}) + response = self.client.get(requested_url) + self.assertNotIn('TEST'.encode('utf-8'), response.content) + class CommentRedirectTest(TestCase):