From: Timo Sirainen <tss@iki.fi>
Date: Wed, 30 Jun 2010 20:33:35 +0000 (+0100)
Subject: master: Improved core dump error messages.
X-Git-Tag: 2.0.rc1~52
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dfcc56dc6c485fe45a3fa18325f047bfaae65019;p=thirdparty%2Fdovecot%2Fcore.git

master: Improved core dump error messages.

--HG--
branch : HEAD
---

diff --git a/src/master/service-process.c b/src/master/service-process.c
index db28035104..5f15dca807 100644
--- a/src/master/service-process.c
+++ b/src/master/service-process.c
@@ -396,17 +396,22 @@ log_coredump(struct service *service, string_t *str, int status)
 
 #ifndef HAVE_PR_SET_DUMPABLE
 	if (!service->set->drop_priv_before_exec && service->uid != 0) {
-		str_append(str, " (core not dumped - set drop_priv_before_exec=yes)");
+		str_append(str, " (core not dumped - set service %s "
+			   "{ drop_priv_before_exec=yes })",
+			   service->set->name);
 		return;
 	}
 	if (*service->set->privileged_group != '\0' && service->uid != 0) {
-		str_append(str, " (core not dumped - privileged_group prevented it)");
+		str_append(str, " (core not dumped - service %s "
+			   "{ privileged_group } prevented it)",
+			   service->set->name);
 		return;
 	}
 #else
 	if (!service->set->login_dump_core &&
 	    service->type == SERVICE_TYPE_LOGIN) {
-		str_append(str, " (core not dumped - add -D parameter to service executable");
+		str_printfa(str, " (core not dumped - add -D parameter to "
+			    "service %s { executable }", service->set->name);
 		return;
 	}
 #endif