From: Volker Lendecke <vl@samba.org>
Date: Wed, 11 Apr 2018 06:27:41 +0000 (+0200)
Subject: credentials: Fix CID 1414796 Explicit null dereferenced
X-Git-Tag: ldb-1.4.0~646
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=dff196a15735ea4dd6946aa6f2efa8a7e8f54b77;p=thirdparty%2Fsamba.git

credentials: Fix CID 1414796 Explicit null dereferenced

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 11 21:58:00 CEST 2018 on sn-devel-144
---

diff --git a/auth/credentials/credentials_secrets.c b/auth/credentials/credentials_secrets.c
index 963024820f3..8d2a3b7a46e 100644
--- a/auth/credentials/credentials_secrets.c
+++ b/auth/credentials/credentials_secrets.c
@@ -122,6 +122,7 @@ static NTSTATUS cli_credentials_set_secrets_lct(struct cli_credentials *cred,
 
 	if ((lct == secrets_tdb_last_change_time) &&
 	    (secrets_tdb_password != NULL) &&
+	    (password != NULL) &&
 	    (strcmp(password, secrets_tdb_password) != 0)) {
 		talloc_free(mem_ctx);
 		return NT_STATUS_NOT_FOUND;