From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Date: Tue, 3 Dec 2024 09:19:29 +0000 (+0100)
Subject: crypto: qce - fix goto jump in error path
X-Git-Tag: v5.10.235~255
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e063d1d59fe6e82ab4edb69cbcf0e582285001e8;p=thirdparty%2Fkernel%2Fstable.git

crypto: qce - fix goto jump in error path

commit 5278275c1758a38199b43530adfc50098f4b41c7 upstream.

If qce_check_version() fails, we should jump to err_dma as we already
called qce_dma_request() a couple lines before.

Cc: stable@vger.kernel.org
Fixes: ec8f5d8f6f76 ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
index ea616b7259aef..84efb9dc5dc3d 100644
--- a/drivers/crypto/qce/core.c
+++ b/drivers/crypto/qce/core.c
@@ -219,7 +219,7 @@ static int qce_crypto_probe(struct platform_device *pdev)
 
 	ret = qce_check_version(qce);
 	if (ret)
-		goto err_clks;
+		goto err_dma;
 
 	spin_lock_init(&qce->lock);
 	tasklet_init(&qce->done_tasklet, qce_tasklet_req_done,