From: Nick Mathewson <nickm@torproject.org>
Date: Fri, 5 Dec 2008 01:35:49 +0000 (+0000)
Subject: Add a couple of sanity-checks for return values that coverity thinks we ought to... 
X-Git-Tag: tor-0.2.1.8-alpha~27
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e06442b64820db59394dce140967a60dd813533a;p=thirdparty%2Ftor.git

Add a couple of sanity-checks for return values that coverity thinks we ought to have.  CIDs 337, 335.

svn:r17485
---

diff --git a/src/or/routerparse.c b/src/or/routerparse.c
index 701012043d..7c061d3b40 100644
--- a/src/or/routerparse.c
+++ b/src/or/routerparse.c
@@ -2552,6 +2552,7 @@ networkstatus_parse_detached_signatures(const char *s, const char *eos)
   }
 
   tok = find_first_by_keyword(tokens, K_CONSENSUS_DIGEST);
+  tor_assert(tok);
   if (strlen(tok->args[0]) != HEX_DIGEST_LEN) {
     log_warn(LD_DIR, "Wrong length on consensus-digest in detached "
              "networkstatus signatures");
diff --git a/src/or/test.c b/src/or/test.c
index c73cf00823..9b05242c40 100644
--- a/src/or/test.c
+++ b/src/or/test.c
@@ -763,6 +763,7 @@ test_crypto(void)
   memset(data1, 6, 1024);
   for (idx = 0; idx < 10; ++idx) {
     i = base64_encode(data2, 1024, data1, idx);
+    test_assert(i >= 0);
     j = base64_decode(data3, 1024, data2, i);
     test_eq(j,idx);
     test_memeq(data3, data1, idx);