From: Marek Polacek <polacek@redhat.com>
Date: Fri, 22 Aug 2014 19:40:28 +0000 (+0000)
Subject: re PR c/61271 (10 * possible coding error with logical not (!))
X-Git-Tag: releases/gcc-5.1.0~5223
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e0bf0dc2c0c17dd4fa6f76c87411906c33dfc3ce;p=thirdparty%2Fgcc.git

re PR c/61271 (10 * possible coding error with logical not (!))

	PR c/61271
	* ira-color.c (coalesced_pseudo_reg_slot_compare): Wrap LHS of
	a comparison in parens.
	* lra-spills.c (pseudo_reg_slot_compare): Wrap LHS of a comparison
	in parens.

From-SVN: r214359
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 0bdcef7d8b52..2b78565a070a 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,11 @@
+2014-08-22  Marek Polacek  <polacek@redhat.com>
+
+	PR c/61271
+	* ira-color.c (coalesced_pseudo_reg_slot_compare): Wrap LHS of
+	a comparison in parens.
+	* lra-spills.c (pseudo_reg_slot_compare): Wrap LHS of a comparison
+	in parens.
+
 2014-08-22  David Malcolm  <dmalcolm@redhat.com>
 
 	* rtl.h (fis_get_condition): Strengthen param "jump" from rtx to
diff --git a/gcc/ira-color.c b/gcc/ira-color.c
index 36c3c879f575..e2ea3596efcb 100644
--- a/gcc/ira-color.c
+++ b/gcc/ira-color.c
@@ -3850,7 +3850,7 @@ coalesced_pseudo_reg_slot_compare (const void *v1p, const void *v2p)
   slot_num2 = -ALLOCNO_HARD_REGNO (a2);
   if ((diff = slot_num1 - slot_num2) != 0)
     return (frame_pointer_needed
-	    || !FRAME_GROWS_DOWNWARD == STACK_GROWS_DOWNWARD ? diff : -diff);
+	    || (!FRAME_GROWS_DOWNWARD) == STACK_GROWS_DOWNWARD ? diff : -diff);
   total_size1 = MAX (PSEUDO_REGNO_BYTES (regno1),
 		     regno_max_ref_width[regno1]);
   total_size2 = MAX (PSEUDO_REGNO_BYTES (regno2),
diff --git a/gcc/lra-spills.c b/gcc/lra-spills.c
index a6fb65bf75fe..8d494af38eb9 100644
--- a/gcc/lra-spills.c
+++ b/gcc/lra-spills.c
@@ -237,7 +237,7 @@ pseudo_reg_slot_compare (const void *v1p, const void *v2p)
   slot_num2 = pseudo_slots[regno2].slot_num;
   if ((diff = slot_num1 - slot_num2) != 0)
     return (frame_pointer_needed
-	    || !FRAME_GROWS_DOWNWARD == STACK_GROWS_DOWNWARD ? diff : -diff);
+	    || (!FRAME_GROWS_DOWNWARD) == STACK_GROWS_DOWNWARD ? diff : -diff);
   total_size1 = GET_MODE_SIZE (lra_reg_info[regno1].biggest_mode);
   total_size2 = GET_MODE_SIZE (lra_reg_info[regno2].biggest_mode);
   if ((diff = total_size2 - total_size1) != 0)