From: Jonathan Rose <jrose@digium.com>
Date: Wed, 25 Jul 2012 21:00:00 +0000 (+0000)
Subject: res_agi: Add message indicating need for \n character in verbose message
X-Git-Tag: 1.8.16.0-rc1~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e0c0f9934d3c02ac7f81a951eb5733291bcbbf1d;p=thirdparty%2Fasterisk.git

res_agi: Add message indicating need for \n character in verbose message

The while loop responsible for reading AGI messages from a fastAGI service
can end up looping indefinitely when an AGI script fails to indicate the end
of a message with a \n character. This patch adds an indication that we are
expecting a \n character to end the message to make it more clear to users
that this is necessary if they are receiving this warning over and over.

(issue ASTERISK-20061)
Reported by: Eike Kuiper


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@370494 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/res/res_agi.c b/res/res_agi.c
index a6f8791520..cb34188ab7 100644
--- a/res/res_agi.c
+++ b/res/res_agi.c
@@ -3539,7 +3539,7 @@ static enum agi_result run_agi(struct ast_channel *chan, char *request, AGI *agi
 					break;
 				len = sizeof(buf) - buflen;
 				if (agidebug)
-					ast_verbose( "AGI Rx << temp buffer %s - errno %s\n", buf, strerror(errno));
+					ast_verbose("AGI Rx << temp buffer %s - errno %s\nNo \\n received, checking again.\n", buf, strerror(errno));
 			}
 
 			if (!buf[0]) {