From: Martin Schwenke <martin@meltin.net>
Date: Wed, 11 Oct 2017 08:04:28 +0000 (+1100)
Subject: ctdb-test: Fix CID 1419118 (Error handling issues)
X-Git-Tag: tevent-0.9.34~202
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e0cf8a4d0d3d820164d333d8968d4a3b599acd54;p=thirdparty%2Fsamba.git

ctdb-test: Fix CID 1419118 (Error handling issues)

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/ctdb/tests/src/fake_ctdbd.c b/ctdb/tests/src/fake_ctdbd.c
index 06b5b2265c9..b0a251af9be 100644
--- a/ctdb/tests/src/fake_ctdbd.c
+++ b/ctdb/tests/src/fake_ctdbd.c
@@ -251,7 +251,11 @@ static bool nodemap_parse(struct node_map *node_map)
 		}
 		node = &node_map->node[node_map->num_nodes];
 
-		ctdb_sock_addr_from_string(ip, &node->addr, false);
+		ret = ctdb_sock_addr_from_string(ip, &node->addr, false);
+		if (ret != 0) {
+			fprintf(stderr, "bad line (%s) - invalid IP\n", line);
+			continue;
+		}
 		ctdb_sock_addr_set_port(&node->addr, CTDB_PORT);
 		node->pnn = pnn;
 		node->flags = flags;