From: Zackery Spytz <zspytz@gmail.com>
Date: Sun, 28 Apr 2019 12:58:52 +0000 (-0600)
Subject: bpo-36745: Fix a possible reference leak in PyObject_SetAttr() (GH-12993)
X-Git-Tag: v3.8.0a4~78
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e0dcb85b7d64153d1741698c04a6736c9669603a;p=thirdparty%2FPython%2Fcpython.git

bpo-36745: Fix a possible reference leak in PyObject_SetAttr() (GH-12993)



https://bugs.python.org/issue36745
---

diff --git a/Objects/object.c b/Objects/object.c
index e7ec7aec490f..589bf365e870 100644
--- a/Objects/object.c
+++ b/Objects/object.c
@@ -1044,8 +1044,10 @@ PyObject_SetAttr(PyObject *v, PyObject *name, PyObject *value)
     }
     if (tp->tp_setattr != NULL) {
         const char *name_str = PyUnicode_AsUTF8(name);
-        if (name_str == NULL)
+        if (name_str == NULL) {
+            Py_DECREF(name);
             return -1;
+        }
         err = (*tp->tp_setattr)(v, (char *)name_str, value);
         Py_DECREF(name);
         return err;