From: Gregory P. Smith Date: Sun, 2 Feb 2025 04:46:56 +0000 (-0800) Subject: gh-119461: Restore the testSocket VSOCK skipUnless removed by PR #119465 (#129561) X-Git-Tag: v3.14.0a5~138 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e1006ce1ded1b18972888ef057718dba6f2c7edd;p=thirdparty%2FPython%2Fcpython.git gh-119461: Restore the testSocket VSOCK skipUnless removed by PR #119465 (#129561) Restore the skipUnless removed by #119465. This test can only pass on virtual machines, not actual machines. actual machines see: ``` self.cli.connect((cid, VSOCKPORT)) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^ OSError: [Errno 19] No such device ``` Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic. --- diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py index faf326d9164e..b77fa3cb2151 100644 --- a/Lib/test/test_socket.py +++ b/Lib/test/test_socket.py @@ -520,6 +520,8 @@ class ThreadedRDSSocketTest(SocketRDSTest, ThreadableTest): @unittest.skipIf(WSL, 'VSOCK does not work on Microsoft WSL') @unittest.skipUnless(HAVE_SOCKET_VSOCK, 'VSOCK sockets required for this test.') +@unittest.skipUnless(get_cid() != 2, # VMADDR_CID_HOST + "This test can only be run on a virtual guest.") class ThreadedVSOCKSocketStreamTest(unittest.TestCase, ThreadableTest): def __init__(self, methodName='runTest'):