From: Raymond Hettinger Date: Sun, 30 Oct 2011 21:29:06 +0000 (-0700) Subject: Issue 13274: Make the pure python code for heapq more closely match the C implementa... X-Git-Tag: v2.7.3rc1~353 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e11a47e2070c9c271da5b26a77c8ab50437e58b4;p=thirdparty%2FPython%2Fcpython.git Issue 13274: Make the pure python code for heapq more closely match the C implementation for an undefined corner case. --- diff --git a/Lib/heapq.py b/Lib/heapq.py index fcaca1344222..6a4e0f4c31ce 100644 --- a/Lib/heapq.py +++ b/Lib/heapq.py @@ -193,6 +193,8 @@ def nlargest(n, iterable): Equivalent to: sorted(iterable, reverse=True)[:n] """ + if n < 0: + return [] it = iter(iterable) result = list(islice(it, n)) if not result: @@ -209,6 +211,8 @@ def nsmallest(n, iterable): Equivalent to: sorted(iterable)[:n] """ + if n < 0: + return [] if hasattr(iterable, '__len__') and n * 10 <= len(iterable): # For smaller values of n, the bisect method is faster than a minheap. # It is also memory efficient, consuming only n elements of space.