From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 6 Aug 2018 09:15:42 +0000 (-0700)
Subject: bpo-19891: Ignore error while writing history file (GH-8483)
X-Git-Tag: v3.6.7rc1~124
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e20d31cdb33bdfee68bce059f9a9c7ce71b035fe;p=thirdparty%2FPython%2Fcpython.git

bpo-19891: Ignore error while writing history file (GH-8483)

(cherry picked from commit b2499669ef2e6dc9a2cdb49b4dc498e078167e26)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
---

diff --git a/Lib/site.py b/Lib/site.py
index 1bd63ccf6a23..86ca2dba61bf 100644
--- a/Lib/site.py
+++ b/Lib/site.py
@@ -418,7 +418,16 @@ def enablerlcompleter():
                 readline.read_history_file(history)
             except IOError:
                 pass
-            atexit.register(readline.write_history_file, history)
+
+            def write_history():
+                try:
+                    readline.write_history_file(history)
+                except (FileNotFoundError, PermissionError):
+                    # home directory does not exist or is not writable
+                    # https://bugs.python.org/issue19891
+                    pass
+
+            atexit.register(write_history)
 
     sys.__interactivehook__ = register_readline
 
diff --git a/Misc/NEWS.d/next/Library/2018-07-26-08-45-49.bpo-19891.Y-3IiB.rst b/Misc/NEWS.d/next/Library/2018-07-26-08-45-49.bpo-19891.Y-3IiB.rst
new file mode 100644
index 000000000000..18e10f5aa3d6
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2018-07-26-08-45-49.bpo-19891.Y-3IiB.rst
@@ -0,0 +1,2 @@
+Ignore errors caused by missing / non-writable homedir while writing history
+during exit of an interactive session.  Patch by Anthony Sottile.