From: Victor Julien <victor@inliniac.net>
Date: Tue, 25 Jun 2013 15:14:02 +0000 (+0200)
Subject: Coverity 1038092 & 1038093: remove dead code
X-Git-Tag: suricata-2.0beta1~93
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e2444f0ed5ebfcac8a721c961423890b4f807213;p=thirdparty%2Fsuricata.git

Coverity 1038092 & 1038093: remove dead code
---

diff --git a/src/app-layer-ssh.c b/src/app-layer-ssh.c
index b2c6489278..2fd7db4884 100644
--- a/src/app-layer-ssh.c
+++ b/src/app-layer-ssh.c
@@ -229,13 +229,8 @@ static int SSHParseServerRecord(Flow *f, void *ssh_state, AppLayerParserState *p
     if ( !(state->flags & SSH_FLAG_SERVER_VERSION_PARSED)) {
         ret = SSHParseServerVersion(f, ssh_state, pstate, input, input_len, output);
         if (ret < 0) {
-            if (ret <= -1) {
-                SCLogDebug("Invalid version string");
-                SCReturnInt(-1);
-            }
-            SCLogDebug("Version string not parsed yet");
-            pstate->parse_field = 0;
-            SCReturnInt(ret);
+            SCLogDebug("Invalid version string");
+            SCReturnInt(-1);
         } else if (state->flags & SSH_FLAG_SERVER_VERSION_PARSED) {
             SCLogDebug("Version string parsed");
             input += input_len - ret;
@@ -560,13 +555,8 @@ static int SSHParseClientRecord(Flow *f, void *ssh_state, AppLayerParserState *p
     if ( !(state->flags & SSH_FLAG_CLIENT_VERSION_PARSED)) {
         ret = SSHParseClientVersion(f, ssh_state, pstate, input, input_len, output);
         if (ret < 0) {
-            if (ret <= -1) {
-                SCLogDebug("Invalid version string");
-                SCReturnInt(-1);
-            }
-            SCLogDebug("Version string not parsed yet");
-            pstate->parse_field = 0;
-            SCReturnInt(0);
+            SCLogDebug("Invalid version string");
+            SCReturnInt(-1);
         } else if (state->flags & SSH_FLAG_CLIENT_VERSION_PARSED) {
             SCLogDebug("Version string parsed");
             input += input_len - ret;