From: Nicholas Nethercote <njn@valgrind.org>
Date: Wed, 24 Aug 2005 13:55:59 +0000 (+0000)
Subject: Minor fixes for problems pointed out by Greg Parker:
X-Git-Tag: svn/VALGRIND_3_1_0~539
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e266e539706300ff95f0f4ff45d441ca467ad9ac;p=thirdparty%2Fvalgrind.git

Minor fixes for problems pointed out by Greg Parker:

* The wrapper for fcntl(F_SETOWN) and fcntl(F_SETSIG) ignores ARG3,
  but should not.

* Linux PRE(sys_umount) doesn't print ARG2.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@4487
---

diff --git a/coregrind/m_syswrap/syswrap-generic.c b/coregrind/m_syswrap/syswrap-generic.c
index 80ae123bd9..41c257e2b6 100644
--- a/coregrind/m_syswrap/syswrap-generic.c
+++ b/coregrind/m_syswrap/syswrap-generic.c
@@ -2600,9 +2600,7 @@ PRE(sys_fcntl)
    case VKI_F_GETFD:
    case VKI_F_GETFL:
    case VKI_F_GETOWN:
-   case VKI_F_SETOWN:
    case VKI_F_GETSIG:
-   case VKI_F_SETSIG:
    case VKI_F_GETLEASE:
       PRINT("sys_fcntl ( %d, %d )", ARG1,ARG2);
       PRE_REG_READ2(long, "fcntl", unsigned int, fd, unsigned int, cmd);
@@ -2614,6 +2612,8 @@ PRE(sys_fcntl)
    case VKI_F_SETFL:
    case VKI_F_SETLEASE:
    case VKI_F_NOTIFY:
+   case VKI_F_SETOWN:
+   case VKI_F_SETSIG:
       PRINT("sys_fcntl[ARG3=='arg'] ( %d, %d, %d )", ARG1,ARG2,ARG3);
       PRE_REG_READ3(long, "fcntl",
                     unsigned int, fd, unsigned int, cmd, unsigned long, arg);
diff --git a/coregrind/m_syswrap/syswrap-linux.c b/coregrind/m_syswrap/syswrap-linux.c
index c4d7a24ba7..089425cad9 100644
--- a/coregrind/m_syswrap/syswrap-linux.c
+++ b/coregrind/m_syswrap/syswrap-linux.c
@@ -168,7 +168,7 @@ PRE(sys_oldumount)
 
 PRE(sys_umount)
 {
-   PRINT("sys_umount( %p )", ARG1);
+   PRINT("sys_umount( %p, %d )", ARG1, ARG2);
    PRE_REG_READ2(long, "umount2", char *, path, int, flags);
    PRE_MEM_RASCIIZ( "umount2(path)", ARG1);
 }