From: Nicholas Nethercote <n.nethercote@gmail.com>
Date: Wed, 17 Nov 2004 18:24:10 +0000 (+0000)
Subject: Add explanatory comment to set_tid_address wrapper.
X-Git-Tag: svn/VALGRIND_3_0_0~1279
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e2a5f870d7a007ba8facaf07ccb5612fe237490a;p=thirdparty%2Fvalgrind.git

Add explanatory comment to set_tid_address wrapper.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@3037
---

diff --git a/coregrind/vg_syscalls.c b/coregrind/vg_syscalls.c
index 66cf3b1063..342d3798e3 100644
--- a/coregrind/vg_syscalls.c
+++ b/coregrind/vg_syscalls.c
@@ -1128,6 +1128,14 @@ POST(sys_ptrace)
 
 PRE(sys_set_tid_address, Special)
 {
+   // We don't let this syscall run, and don't do anything to simulate it
+   // ourselves -- it becomes a no-op!  Why?  Tom says:
+   // 
+   //   I suspect this is deliberate given that all the user level threads
+   //   are running in the same kernel thread under valgrind so we probably
+   //   don't want to be calling the actual system call here.
+   //
+   // Hmm.
    PRINT("sys_set_tid_address ( %p )", arg1);
    PRE_REG_READ1(long, "set_tid_address", int *, tidptr);
 }