From: Taylor Yu <catalyst@torproject.org>
Date: Mon, 2 Oct 2017 21:09:28 +0000 (-0500)
Subject: Don't move gcov output to root directory
X-Git-Tag: tor-0.3.3.0-alpha-dev~14^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e31ffb274132662e2ce13439a52554022154773c;p=thirdparty%2Ftor.git

Don't move gcov output to root directory

In scripts/test/coverage, avoid attempting to move gcov output files
to the root directory when given no arguments.  Fixes bug 23741.
---

diff --git a/changes/bug23741 b/changes/bug23741
new file mode 100644
index 0000000000..92f06f5270
--- /dev/null
+++ b/changes/bug23741
@@ -0,0 +1,4 @@
+  o Minor bugfixes (testing):
+    - Prevent scripts/test/coverage from attempting to move gcov
+      output to the root directory.  Fixes bug 23741; bugfix on
+      0.2.5.1-alpha.
diff --git a/scripts/test/coverage b/scripts/test/coverage
index f4ae475828..f10c5afaae 100755
--- a/scripts/test/coverage
+++ b/scripts/test/coverage
@@ -29,7 +29,7 @@ for fn in src/or/*.c src/common/*.c; do
           gcov -o $on $fn
           if [ -e $GC ]
           then
-            if [ -n $dst ]
+            if [ -d "$dst" ]
             then
               mv $GC $dst/$GC
             fi