From: Paul Eggert Date: Fri, 24 Jun 2005 02:13:39 +0000 (+0000) Subject: * NEWS: Don't worry about spaces in bindir etc. Only srcdir and working X-Git-Tag: AUTOCONF-2.59c~319 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=e32eb1d0fe7d91cbd208bf6c369f5e3db9f98daf;p=thirdparty%2Fautoconf.git * NEWS: Don't worry about spaces in bindir etc. Only srcdir and working directory have inherent problems with special characters like spaces, due to limitations in Make syntax. Problem reported by Alexandre Duret-Lutz. * lib/autoconf/general.m4 (_AC_INIT_DIRCHECK): Implement the above. Also, fix Tru64 porting problem with shell patterns, reported by Ralf Wildenhues. --- diff --git a/ChangeLog b/ChangeLog index 7aba50d94..44e35ae9a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2005-06-23 Paul Eggert + + * NEWS: Don't worry about spaces in bindir etc. Only srcdir and working + directory have inherent problems with special characters like spaces, + due to limitations in Make syntax. Problem reported by Alexandre + Duret-Lutz. + * lib/autoconf/general.m4 (_AC_INIT_DIRCHECK): Implement the above. + Also, fix Tru64 porting problem with shell patterns, + reported by Ralf Wildenhues. + 2005-06-23 Ralf Wildenhues * doc/autoconf.texi (Subdirectories): Fix markup typos. diff --git a/NEWS b/NEWS index 46ae1cce3..e7f66f845 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,7 @@ * Major changes in Autoconf 2.59c -** The configure command now warns you if you attempt to use a directory - whose name contains a special character like space, newline, or "\". +** The configure command now diagnoses attempts to use a working or source + directory whose name contains a special character like space, newline, or "\". Such names are not supported, and can cause "configure" to crash. ** The configure command now redirects standard input from /dev/null, diff --git a/lib/autoconf/general.m4 b/lib/autoconf/general.m4 index fc3abb4c9..a6562144a 100644 --- a/lib/autoconf/general.m4 +++ b/lib/autoconf/general.m4 @@ -467,12 +467,9 @@ ac_pwd=`pwd` && test -n "$ac_pwd" || AC_MSG_ERROR([Working directory cannot be determined]) ac_pat="[[\$][{][_$as_cr_Letters][_$as_cr_alnum]*[}]]" +ac_pat1='*[)]*' -for ac_var in ac_pwd srcdir \ - bindir sbindir libexecdir datarootdir datadir \ - sysconfdir sharedstatedir localstatedir includedir \ - oldincludedir docdir infodir htmldir dvidir pdfdir \ - psdir libdir localedir mandir +for ac_var in ac_pwd srcdir do # Remove references to shell or make variables. eval ac_dir=\$$ac_var @@ -492,7 +489,7 @@ do # Preserve that tab character below! case $ac_dirx in '' | -* | */-* | *' -'* | *' '* | *' '* | *\"* | *\#* | *\$* | *\&* | *\'* | *\(* | *\)* | \ +'* | *' '* | *' '* | *\"* | *\#* | *\$* | *\&* | *\'* | *\(* | $ac_pat1 | \ *\** | *\;* | *\<* | *\=* | *\>* | *\?* | *\@<:@* | *\\* | *\`* | \ *\|* | \~*) AC_MSG_ERROR([$ac_var directory name `$ac_dir' has special characters]);;